martinzink commented on code in PR #1642:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311587118


##########
extensions/procfs/CpuStat.h:
##########
@@ -34,7 +34,7 @@ class CpuStatData {
  public:
   static std::optional<CpuStatData> parseCpuStatLine(std::istream& iss);
 
-  auto operator<=>(const CpuStatData& rhs) const = default;
+  bool operator>(const CpuStatData& rhs) const;

Review Comment:
   What was the problem with the default spaceship operator?



##########
.github/workflows/ci.yml:
##########
@@ -181,8 +181,8 @@ jobs:
           name: ubuntu-binaries
           path: build/bin
   ubuntu_20_04_clang:

Review Comment:
   The name of the job was not updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to