fgerlits commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1328737637
########## libminifi/include/utils/TimeUtil.h: ########## @@ -35,15 +35,15 @@ #include "StringUtils.h" // libc++ doesn't define operator<=> on durations, and apparently the operator rewrite rules don't automagically make one -#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 16000 +#if defined(_LIBCPP_VERSION) Review Comment: According to cppreference, `operator<=>(duration, duration)` should exist in C++20, so this looks like a bug/not-yet-implemented feature. Can we add a static assert here which will fail when `libc++` fixes/implements this? Otherwise, we won't notice that this workaround can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
