martinzink commented on code in PR #1634: URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1320137150
########## extensions/smb/FetchSmb.cpp: ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "FetchSmb.h" +#include "core/Resource.h" +#include "utils/file/FileReaderCallback.h" + +namespace org::apache::nifi::minifi::extensions::smb { + +void FetchSmb::initialize() { + setSupportedProperties(Properties); + setSupportedRelationships(Relationships); +} + +void FetchSmb::onSchedule(const std::shared_ptr<core::ProcessContext>& context, const std::shared_ptr<core::ProcessSessionFactory>&) { + gsl_Expects(context); + if (auto connection_controller_name = context->getProperty(FetchSmb::ConnectionControllerService)) { + smb_connection_controller_service_ = std::dynamic_pointer_cast<SmbConnectionControllerService>(context->getControllerService(*connection_controller_name)); + } + if (!smb_connection_controller_service_) { + throw minifi::Exception(ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "Missing SMB Connection Controller Service"); + } Review Comment: Its required on NiFi aswell and if it were optional that would mess up the interface because the output attributes and processor properties often relative to the SMB access location. A mounted smb location would just look like a normal filepath and we would have to reverse lookup and make sure if its an SMB location or not (fail if its not?) and also to check if it changed between triggers. I am not sure if it worth the effort and the divergence from NiFi's interface. Maybe we could just nudge the users to the right direction in the in the documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
