martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1324606530
##########
cmake/MiNiFiOptions.cmake:
##########
@@ -85,6 +85,7 @@ if (WIN32)
add_minifi_option(MSI_REDISTRIBUTE_UCRT_NONASL "Redistribute Universal C
Runtime DLLs with the MSI generated by CPack. The resulting MSI is not
distributable under Apache 2.0." OFF)
add_minifi_option(ENABLE_WEL "Enables the suite of Windows Event Log
extensions." OFF)
add_minifi_option(ENABLE_PDH "Enables PDH support." OFF)
+ add_minifi_option(ENABLE_SMB "Enables SMB support." OFF)
Review Comment:
I've enabled it by default on windows in
https://github.com/apache/nifi-minifi-cpp/pull/1634/commits/5cb7e0d0db3b35d76961174779bf37bdb607afbf
and
https://github.com/apache/nifi-minifi-cpp/pull/1634/commits/67706f0a1f1dda56b0dcdad1f26b42244662f8d4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
