levilentz opened a new pull request, #7677: URL: https://github.com/apache/nifi/pull/7677
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary This brings back https://github.com/apache/nifi/pull/4204 which went stale. In my changes I have been able to address: * https://github.com/apache/nifi/pull/4204#discussion_r534548392 * https://github.com/apache/nifi/pull/4204#discussion_r534549148 The new code consolidates the script submissions and gremlin bytecode submission functionality into one service. I am still working to make a unit test to test this with in-memory janusgraph, but I have tested the following extensively in the nifi UI: * Script Submission with service settings * Bytecode Submission with yaml file settings Using a localized janusgarph server. I am in the process of testing the other two options (script submission with yaml, and bytecode with service settings), but expect them to work as expected. I was unable to replicate: * https://github.com/apache/nifi/pull/4204#issuecomment-737444733 and would appreciate if @mattyb149 could detail exactly how he was creating that error so I can address This code is ready for review, and I do not anticipate additional functionality at this time save for the addition of unit tests. [NIFI-7355](https://issues.apache.org/jira/browse/NIFI-7355) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [N/A] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 I am unable to complete the contrib-check because the neo4j bundle is complaining about in-complete licenses. Should I update those? ### Licensing - [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [X] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
