levilentz commented on PR #7677: URL: https://github.com/apache/nifi/pull/7677#issuecomment-1714864098
> Thanks for the contribution @levilentz. Without going into the code details for now, there are two items worth highlighting for adjustment: > > 1. There are several Checkstyle warnings shown in the Static Analysis job that need to be corrected: > > > ``` > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[21,43] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.nifi.annotation.behavior.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[26,34] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.nifi.components.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[45,20] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - javax.script.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[47,17] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*. > Warning: src/test/java/org/apache/nifi/graph/TestableGremlinClientService.java:[20,8] (imports) UnusedImports: Unused import - org.apache.tinkerpop.gremlin.driver.Client. > ``` > > 2. New unit tests should use Java instead of Groovy, so the `GremlinByteCodeClientIT` class should be refactored. Thank you for the quick turn @exceptionfactory -- I have just simply removed the groovy IT tests in the most recent commit and have fixed the check style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
