joewitt commented on code in PR #7806:
URL: https://github.com/apache/nifi/pull/7806#discussion_r1340296356
##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DefaultDataSourceValues.java:
##########
@@ -31,35 +29,28 @@ public Long getLongValue() {
}
},
MAX_TOTAL_CONNECTIONS("8"),
+
/**
* Copied from {@link GenericObjectPoolConfig#DEFAULT_MIN_IDLE} in
Commons-DBCP 2.7.0
*/
MIN_IDLE("0"),
+
/**
* Copied from {@link GenericObjectPoolConfig#DEFAULT_MAX_IDLE} in
Commons-DBCP 2.7.0
*/
MAX_IDLE("8"),
- /**
Review Comment:
Whey remove several of these Javadoc statements but not all of them? Do we
know why we're copying the code/values here from the stated library and not
instead just referring to these values from the library itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
