markap14 commented on code in PR #7806:
URL: https://github.com/apache/nifi/pull/7806#discussion_r1340332144
##########
nifi-nar-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DefaultDataSourceValues.java:
##########
@@ -31,35 +29,28 @@ public Long getLongValue() {
}
},
MAX_TOTAL_CONNECTIONS("8"),
+
/**
* Copied from {@link GenericObjectPoolConfig#DEFAULT_MIN_IDLE} in
Commons-DBCP 2.7.0
*/
MIN_IDLE("0"),
+
/**
* Copied from {@link GenericObjectPoolConfig#DEFAULT_MAX_IDLE} in
Commons-DBCP 2.7.0
*/
MAX_IDLE("8"),
- /**
Review Comment:
I don't know why they were copied. I tried to avoid changing any logic that
I wasn't 100% confident about. The ones that were removed, I believe,
referenced deprecated methods. I used IntelliJ to just find any and all
deprecated references and went through them 1-by-1, addressing. I made some
other trivial updates that IntelliJ recommended as well, but largely didn't
change anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
