lordgamez commented on code in PR #1671:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341020326
##########
extensions/systemd/libwrapper/DlopenWrapper.cpp:
##########
@@ -72,7 +72,7 @@ class DlopenJournal : public Journal {
template<typename F>
F loadSymbol(const char* const symbol_name) {
// The cast below is supported by POSIX platforms.
https://stackoverflow.com/a/1096349
- F const symbol = (F)dlsym(libhandle_.get(), symbol_name);
+ F const symbol = reinterpret_cast<F>(dlsym(libhandle_.get(), symbol_name));
Review Comment:
Good point, updated in 9d15d87a77f8e03e0863f8910fc540d9665b9d8f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
