szaszm commented on code in PR #1671:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1671#discussion_r1341418984
##########
extensions/standard-processors/processors/PutTCP.cpp:
##########
@@ -215,7 +215,7 @@ asio::awaitable<std::error_code>
ConnectionHandler<SocketType>::establishNewConn
continue;
}
if (max_size_of_socket_send_buffer_)
-
socket.lowest_layer().set_option(TcpSocket::send_buffer_size(*max_size_of_socket_send_buffer_));
+
socket.lowest_layer().set_option(TcpSocket::send_buffer_size(*max_size_of_socket_send_buffer_));
// NOLINT(google-readability-casting)
Review Comment:
I think casts are pretty well covered by other checks. I would just disable
this one due to the false positives, instead of littering the code with NOLINTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
