martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1348383857
##########
extensions/librdkafka/ConsumeKafka.cpp:
##########
@@ -133,7 +133,7 @@ void ConsumeKafka::create_topic_partition_list() {
// This might happen until the cross-overship between processors and
connections are settled
rd_kafka_resp_err_t subscribe_response = rd_kafka_subscribe(consumer_.get(),
kf_topic_partition_list_.get());
if (RD_KAFKA_RESP_ERR_NO_ERROR != subscribe_response) {
- logger_->log_error("rd_kafka_subscribe error %d: %s", subscribe_response,
rd_kafka_err2str(subscribe_response));
+ logger_->log_error("rd_kafka_subscribe error {}: {}",
static_cast<int>(subscribe_response), rd_kafka_err2str(subscribe_response));
Review Comment:
good idea, changed them in
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/eee46a1ad105b06949245579823badde5f234c86#diff-7aaf131a97c759e9535682828cf6a056cd19f11e8b75f0b37354c602b060a222R136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
