martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1356658920
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -235,20 +235,20 @@ void StructuredConfiguration::parseProcessorNode(const
Node& processors_node, co
if (procCfg.schedulingStrategy == "TIMER_DRIVEN" ||
procCfg.schedulingStrategy == "EVENT_DRIVEN") {
if (auto scheduling_period =
utils::timeutils::StringToDuration<std::chrono::nanoseconds>(procCfg.schedulingPeriod))
{
- logger_->log_debug("convert: parseProcessorNode: schedulingPeriod =>
[%" PRId64 "] ns", scheduling_period->count());
+ logger_->log_debug("convert: parseProcessorNode: schedulingPeriod =>
[{}] ns", scheduling_period->count());
Review Comment:
👍 I've simplified these remaining chrono duration logging in
https://github.com/apache/nifi-minifi-cpp/commit/92a5f25321f81e3b7bf7a5d12d611d450ea432dd,
but had to revert the MQTT ones due to some mysterious centos warnings in
https://github.com/apache/nifi-minifi-cpp/commit/1704d2444a12b53ce27797c17ef4dc5bb2ff0399
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -235,20 +235,20 @@ void StructuredConfiguration::parseProcessorNode(const
Node& processors_node, co
if (procCfg.schedulingStrategy == "TIMER_DRIVEN" ||
procCfg.schedulingStrategy == "EVENT_DRIVEN") {
if (auto scheduling_period =
utils::timeutils::StringToDuration<std::chrono::nanoseconds>(procCfg.schedulingPeriod))
{
- logger_->log_debug("convert: parseProcessorNode: schedulingPeriod =>
[%" PRId64 "] ns", scheduling_period->count());
+ logger_->log_debug("convert: parseProcessorNode: schedulingPeriod =>
[{}] ns", scheduling_period->count());
Review Comment:
👍 I've simplified these remaining chrono duration logging in
https://github.com/apache/nifi-minifi-cpp/commit/92a5f25321f81e3b7bf7a5d12d611d450ea432dd,
but had to revert the MQTT ones due to some mysterious centos warnings in
https://github.com/apache/nifi-minifi-cpp/commit/1704d2444a12b53ce27797c17ef4dc5bb2ff0399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
