martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1356660563


##########
libminifi/src/core/logging/LoggerConfiguration.cpp:
##########
@@ -305,7 +305,7 @@ std::shared_ptr<spdlog::logger> 
LoggerConfiguration::get_logger(const std::share
   }
   if (logger != nullptr) {
     const auto levelView(spdlog::level::to_string_view(level));
-    logger->log_debug("%s logger got sinks from namespace %s and level %s from 
namespace %s", name, sink_namespace_str, std::string(levelView.begin(), 
levelView.end()), level_namespace_str);
+    logger->log_debug("{} logger got sinks from namespace {} and level {} from 
namespace {}", name, sink_namespace_str, std::string(levelView.begin(), 
levelView.end()), level_namespace_str);

Review Comment:
   :+1: 
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/6a5aebd7790dbf83d5418c03b6168ae3a0b6bf38#diff-9a79d1f5586ffc516b0d49c31345d7938befc39eef2e8f584dddee618dc9d942R307



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to