[
https://issues.apache.org/jira/browse/NIFI-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743041#comment-15743041
]
ASF GitHub Bot commented on NIFI-3188:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1321
NIFI-3188: Added unit test to test corner cases
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3188
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1321
----
commit 39da2731258552fc54b79c081bf8e71b5a3527a0
Author: Mark Payne <[email protected]>
Date: 2016-12-12T20:23:40Z
NIFI-3188: Added unit test to test corner cases
----
> Test corner cases of StreamDemarcator
> -------------------------------------
>
> Key: NIFI-3188
> URL: https://issues.apache.org/jira/browse/NIFI-3188
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
>
> I've found a corner case that existed in StreamDemarcator in the 1.0.0
> baseline. The corner case has been addressed already in the 1.1.0 baseline.
> However, this ticket is to add additional unit tests for StreamDemarcator
> that expose the issue in 1.0.0 and show that it is fixed in 1.1.0. This will
> be helpful to guard against regressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
