[ 
https://issues.apache.org/jira/browse/NIFI-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746938#comment-15746938
 ] 

ASF GitHub Bot commented on NIFI-3188:
--------------------------------------

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1321
  
    Reviewed. Confirmed this test case fails with rel/nifi-1.0.0 tag, but 
passes with the latest master as expected. With 1.0.0, it produced following 
assertion error:
    
    ```
    java.lang.AssertionError: array lengths differed, expected.length=2 
actual.length=3
    
         at org.junit.Assert.fail(Assert.java:88)
         at 
org.junit.internal.ComparisonCriteria.assertArraysAreSameLength(ComparisonCriteria.java:76)
         at 
org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:37)
         at org.junit.Assert.internalArrayEquals(Assert.java:532)
         at org.junit.Assert.assertArrayEquals(Assert.java:341)
         at org.junit.Assert.assertArrayEquals(Assert.java:352)
         at 
org.apache.nifi.stream.io.util.StreamDemarcatorTest.testOnBufferCorners(StreamDemarcatorTest.java:243)
    ```
    
    Thanks @markap14 merged this into master!


> Test corner cases of StreamDemarcator
> -------------------------------------
>
>                 Key: NIFI-3188
>                 URL: https://issues.apache.org/jira/browse/NIFI-3188
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.1.1
>
>
> I've found a corner case that existed in StreamDemarcator in the 1.0.0 
> baseline. The corner case has been addressed already in the 1.1.0 baseline. 
> However, this ticket is to add additional unit tests for StreamDemarcator 
> that expose the issue in 1.0.0 and show that it is fixed in 1.1.0. This will 
> be helpful to guard against regressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to