ChrisSamo632 commented on code in PR #7995:
URL: https://github.com/apache/nifi/pull/7995#discussion_r1386277971
##########
.github/workflows/ci-workflow.yml:
##########
@@ -160,22 +159,19 @@ jobs:
${{ env.MAVEN_COMPILE_COMMAND }}
- name: Maven Verify
env:
- NIFI_CI_LOCALE: >-
- -Duser.language=en
- -Duser.country=AU
- SUREFIRE_OPTS: >-
Review Comment:
It might be possible to retain these args (thus allowing use of JaCoCo in
other Actions in future if desired, without needing to change the `mvn` args,
by using something like:
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jaCoCoArgLine} -Xmx1024m</argLine>
</configuration>
</plugin>
```
within `<pluginManagement/>`, and (within `<build/>`):
```xml
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<executions>
<execution>
<id>default-prepare-agent</id>
<goals>
<goal>prepare-agent</goal>
</goals>
<configuration>
<propertyName>jaCoCoArgLine</propertyName>
</configuration>
</execution>
</executions>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
