exceptionfactory commented on code in PR #7995:
URL: https://github.com/apache/nifi/pull/7995#discussion_r1386620132
##########
pom.xml:
##########
@@ -29,6 +29,7 @@
<module>nifi-framework-api</module>
<module>nifi-server-api</module>
<module>nifi-bootstrap</module>
+ <module>nifi-code-coverage</module>
Review Comment:
Thanks for the feedback. I considered the option of individually running the
JaCoCo [report](https://www.jacoco.org/jacoco/trunk/doc/report-mojo.html) goal,
but I went with the
[report-aggregate](https://www.jacoco.org/jacoco/trunk/doc/report-aggregate-mojo.html)
goal and aggregating module to avoid changing individual Maven configurations.
I agree that neither solution is perfect, as each approach requires an extra
element to consider when adding new modules. However, after making recent
changes to remove the need for JavaDoc and source plugin skipping in individual
modules, I went with the centralized approach. Another positive of this option
is that if we don't see coverage information for a particular module, there is
only one place to check, versus going through multiple modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
