simonbence commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1417093557
##########
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java:
##########
@@ -22,6 +22,7 @@
/**
*/
public class ConnectionStatus implements Cloneable {
+ private long createdAtInMs;
Review Comment:
Based on most usage I would think a time related information would make
sense within status (at what time the status snapshot is relevant). I am not
sure this is true for all usages but the current setup on main (these two
coupled information travels together) does not seem straightforward to me. I
cannot rule out however a possible third solution which complies with both
things.
Instant is a good idea. I think I went down this road because some already
contained creation time in this flavor but the `Instant` really makes more
sense (especially that we convert it to instant many places already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
