exceptionfactory commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1419100364
##########
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java:
##########
@@ -22,6 +22,7 @@
/**
*/
public class ConnectionStatus implements Cloneable {
+ private long createdAtInMs;
Review Comment:
Thanks for the reply @simonbence.
Reviewing the usage, in particular reference to `AbstractEventAccess`, the
`created` timestamp here appears somewhat ambiguous. The usage in
`AbstractEventAccess` appears to populate this value based on the current
system time. From that perspective, `created` appears to mean the time at which
the Status object was created. However, the rest of the properties in the
Status object refer to the referenced object itself, such as the Connection or
Process Group. From that perspective, I would have expected a created timestamp
to mean the time at which the component was created. This highlights the
problem with adding this property to the NiFi API.
Although it might be possible to clarify the ambiguity with a different
name, it still falls into a different category than all of the other properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
