[ 
https://issues.apache.org/jira/browse/NIFI-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794214#comment-17794214
 ] 

Pierre Villard commented on NIFI-12236:
---------------------------------------

I definitely agree on the documentation aspect and it'd be nice to have the PR 
update the admin-guide with as much documentation as possible regarding this 
implementation (its value, its configuration, etc).

There is already a bit here: 
[https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#persistent-repository]
 

Regarding your points:
{quote} # Avoid making this the default. It can be opted into.{quote}
Definite agree here. Let's not change the default at this point.
{quote}2. Avoid making nifi-api changes.
{quote}
I believe [~simonbence] gave the reasons as why the changes are making sense 
and since we're still working towards NiFi 2.0, I believe this is worth 
discussing but I believe the current work can also be done without API change 
if that's the real blocker.
{quote}3. Move this into its own nar instead of the core framework nar. It can 
certainly still be included as it is today.
{quote}
Yeah, ideally every repository in NiFi could be a pluggable endpoint where a 
NAR can be provided with a given implementation. I'd see a lot of value there 
and I believe it's been mentioned a few times in the community. However, making 
the repositories a pluggable endpoint would likely be a significant effort and, 
in my opinion, it should be a follow up effort, not a prerequisite for the 
current work to be included (which is what you said, if I understood you 
correctly).

> Improving fault tolerancy of the QuestDB backed metrics repository
> ------------------------------------------------------------------
>
>                 Key: NIFI-12236
>                 URL: https://issues.apache.org/jira/browse/NIFI-12236
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Simon Bence
>            Assignee: Simon Bence
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Based on the related discussion on the dev email list, the QuestDB handling 
> of the metrics repository needs to be improved to have better fault tolerance 
> in order to be possible to use as a viable option for default metrics data 
> store. This should primarily focus on handling unexpeted database events like 
> corrupted database or loss of space on the disk. Any issues should be handled 
> with an attempt to keep the database service healthy but in case of that is 
> impossible, the priority is to keep NiFi and the core services running, even 
> with the price of metrics collection / presentation outage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to