[
https://issues.apache.org/jira/browse/NIFI-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794244#comment-17794244
]
Simon Bence commented on NIFI-12236:
------------------------------------
Hei [~pvillard]!
Thanks for mentioning the admin guide! I forgot to add the newly wired out
properties indeed. I will add those during the review.
1. I think we agreed on the defaulting, with review changes it will be changed
back as well
2. As this looks to be more a nuanced question and I already have a discussion
about it on the PR with David Hendermann, I suggest to continue this topic
there. I am open for reverting those changes but before just doing that, I
would like to be sure that the intentions for the change are clear.
3. I am not sure what Joe meant under moving it into a nar. If it is the
already mentioned pluggability (which I totally in line with in the long run) I
think it is not something to add to this PR, which is more like a glorified
refactor story. If it is about something else, could you please specifiy it
[~joewitt] ? (Note: the actual QuestDB related code is in a separate jar. All
the code remained in the `nifi-framework-core` is related to the actual
repository implementation (counterpart of the Volatile implementation
> Improving fault tolerancy of the QuestDB backed metrics repository
> ------------------------------------------------------------------
>
> Key: NIFI-12236
> URL: https://issues.apache.org/jira/browse/NIFI-12236
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Simon Bence
> Assignee: Simon Bence
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Based on the related discussion on the dev email list, the QuestDB handling
> of the metrics repository needs to be improved to have better fault tolerance
> in order to be possible to use as a viable option for default metrics data
> store. This should primarily focus on handling unexpeted database events like
> corrupted database or loss of space on the disk. Any issues should be handled
> with an attempt to keep the database service healthy but in case of that is
> impossible, the priority is to keep NiFi and the core services running, even
> with the price of metrics collection / presentation outage.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)