dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1424437510
########## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ########## @@ -55,7 +55,7 @@ public void testResponseQueueDrained() throws TimeoutException, IOException { final Map<String, String> exchangeToRoutingKeymap = Collections.singletonMap("myExchange", "key1"); final TestConnection connection = new TestConnection(exchangeToRoutingKeymap, routingMap); - final AMQPConsumer consumer = new AMQPConsumer(connection, "queue1", true, processorLog); + final AMQPConsumer consumer = new AMQPConsumer(connection, "queue1", true, 0, processorLog); Review Comment: Create a static final variable to clearly indicate the default prefetch count is being used e.g. `private static final int DEFAULT_PREFETCH_COUNT = 0;` similarly to what you did in `TestChannel` where you declared a variable for `prefetchCount` ```suggestion final AMQPConsumer consumer = new AMQPConsumer(connection, "queue1", true, DEFAULT_PREFETCH_COUNT, processorLog); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org