MooseTheBrown commented on code in PR #8146:
URL: https://github.com/apache/nifi/pull/8146#discussion_r1425103142
##########
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java:
##########
@@ -80,30 +80,30 @@ public void testConsumerHandlesCancelling() throws
IOException {
@Test
public void failOnNullConnection() {
- assertThrows(IllegalArgumentException.class, () -> new
AMQPConsumer(null, null, true, processorLog));
+ assertThrows(IllegalArgumentException.class, () -> new
AMQPConsumer(null, null, true, 0, processorLog));
}
@Test
public void failOnNullQueueName() {
assertThrows(IllegalArgumentException.class, () -> {
Connection conn = new TestConnection(null, null);
- new AMQPConsumer(conn, null, true, processorLog);
+ new AMQPConsumer(conn, null, true, 0, processorLog);
});
}
@Test
public void failOnEmptyQueueName() {
assertThrows(IllegalArgumentException.class, () -> {
Connection conn = new TestConnection(null, null);
- new AMQPConsumer(conn, " ", true, processorLog);
+ new AMQPConsumer(conn, " ", true, 0, processorLog);
});
}
@Test
public void failOnNonExistingQueue() {
assertThrows(IOException.class, () -> {
Connection conn = new TestConnection(null, null);
- try (AMQPConsumer consumer = new AMQPConsumer(conn, "hello", true,
processorLog)) {
+ try (AMQPConsumer consumer = new AMQPConsumer(conn, "hello", true,
0, processorLog)) {
Review Comment:
Fixed
##########
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java:
##########
@@ -117,7 +117,7 @@ public void
validateSuccessfullConsumeWithEmptyQueueDefaultExchange() throws Exc
exchangeToRoutingKeymap.put("", "queue1");
Connection conn = new TestConnection(exchangeToRoutingKeymap,
routingMap);
- try (AMQPConsumer consumer = new AMQPConsumer(conn, "queue1", true,
processorLog)) {
+ try (AMQPConsumer consumer = new AMQPConsumer(conn, "queue1", true, 0,
processorLog)) {
Review Comment:
Fixed
##########
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java:
##########
@@ -132,9 +132,20 @@ public void validateSuccessfullConsumeWithEmptyQueue()
throws Exception {
Connection conn = new TestConnection(exchangeToRoutingKeymap,
routingMap);
conn.createChannel().basicPublish("myExchange", "key1", null, "hello
Joe".getBytes());
- try (AMQPConsumer consumer = new AMQPConsumer(conn, "queue1", true,
processorLog)) {
+ try (AMQPConsumer consumer = new AMQPConsumer(conn, "queue1", true, 0,
processorLog)) {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
