EndzeitBegins commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1865155224
Thank you for working on this @mattyb149. 👍🏻 I just glanced over the code and have two remarks. Is there a reason, there is no test added for the `OracleDatabaseAdapter` implementation? Does it make sense to populate the columns into the `StringBuilder` directly, instead of putting them into a `List` and only then joining them into the `StringBuilder`. I was under the impression that the `StringBuilder` is especially designed for these kinds of iterative `String` creations. However, Java is not my primary language, so I might be in the wrong here. 🤷🏻♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
