mattyb149 commented on PR #8175: URL: https://github.com/apache/nifi/pull/8175#issuecomment-1866377704
I didn't add the unit test to the older OracleDatabaseAdapter because it was basically copy/paste, but since the new code is too, I will add that test to it. The only reason for using the List instead of the StringBuilder was for the join(), I felt it awkward to have to use a `for` loop and add a comma if `i != 0`. If there are performance-related concerns I can change that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
