adamdebreceni commented on code in PR #1710:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1710#discussion_r1441605139
##########
libminifi/test/unit/StagingQueueTests.cpp:
##########
@@ -92,7 +92,7 @@ TEST_CASE("Modify and overflow triggered automatic commit",
"[TestStagingQueue4]
}
queue.modify([] (MockItem& item) {
// a new item has been allocated
- REQUIRE(item.data_ == "");
+ REQUIRE(item.data_.empty());
Review Comment:
catch deconstructs the expression and logs the left-and right-hand side of
an equality on failure, whereas with the change we only learn that it is not
empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
