fgerlits commented on code in PR #1710:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1710#discussion_r1441657439
##########
libminifi/test/unit/StagingQueueTests.cpp:
##########
@@ -92,7 +92,7 @@ TEST_CASE("Modify and overflow triggered automatic commit",
"[TestStagingQueue4]
}
queue.modify([] (MockItem& item) {
// a new item has been allocated
- REQUIRE(item.data_ == "");
+ REQUIRE(item.data_.empty());
Review Comment:
True, this is one of the more questionable clang-tidy checks, but in this
case, I think it makes sense:
* start out with an empty queue
* add something
* commit (explicitly or implicitly)
* check that the (newly started) queue is empty.
So in this particular case, I would leave it as `.empty()`, but I'll change
it if you think `== ""` would/could give us useful information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
