lordgamez commented on code in PR #1708:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1445844105


##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -900,4 +918,131 @@ void StructuredConfiguration::addNewId(const std::string& 
uuid) {
   }
 }
 
+void StructuredConfiguration::encryptSensitivePropertiesInYaml(YAML::Node 
property_yamls, const std::map<std::string, Property>& properties) const {
+  for (auto kv : property_yamls) {

Review Comment:
   Minor: this could be const ref
   
   ```suggestion
     for (const auto& kv : property_yamls) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to