fgerlits commented on code in PR #1708:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1445957906
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -900,4 +918,131 @@ void StructuredConfiguration::addNewId(const std::string&
uuid) {
}
}
+void StructuredConfiguration::encryptSensitivePropertiesInYaml(YAML::Node
property_yamls, const std::map<std::string, Property>& properties) const {
+ for (auto kv : property_yamls) {
Review Comment:
The yaml_cpp API is quite ̶b̶a̶d̶ unusual: `*YAML::Node::begin()` returns
an object by value, so changing the type of `kv` to `const&` would bind it to
this temporary object.
I think that would be misleading: it's not really `const`, as we modify
`property_yamls` (indirectly) through `kv` at line 932; and it's not really a
reference to anything inside `property_yamls` (it's a reference to a temporary
object).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
