mcgilman commented on code in PR #8233:
URL: https://github.com/apache/nifi/pull/8233#discussion_r1449297004
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##########
@@ -208,7 +208,7 @@ export class ControllerServiceTable implements
AfterViewInit {
}
canConfigure(entity: ControllerServiceEntity): boolean {
- return this.canRead(entity) && this.canWrite(entity) &&
this.isDisabled(entity);
+ return this.canRead(entity) && this.canWrite(entity);
Review Comment:
Current NiFi UI does allow the configuration dialog to open when the
component is Enabled. This was introduced in an effort that removed the
read-only specific dialog and updated the configuration dialog to support both
read-only and configuration modes. The new UI currently does not support a
read-only dialog from within the configuration dialog. We do have a line item
in NIFI-12400 to introduce this behavior. Once the behavior is in place, we
would want to remove the disabled condition here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]