scottyaslan commented on code in PR #8233: URL: https://github.com/apache/nifi/pull/8233#discussion_r1449457844
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/flow-analysis-rules/flow-analysis-rule-table/flow-analysis-rule-table.component.html: ########## @@ -0,0 +1,145 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="relative h-full border"> + <div class="flow-analysis-rule-table listing-table absolute inset-0 overflow-y-auto"> + <table mat-table [dataSource]="dataSource" matSort matSortDisableClear> + <!-- More Details Column --> + <ng-container matColumnDef="moreDetails"> + <th mat-header-cell *matHeaderCellDef></th> + <td mat-cell *matCellDef="let item"> + <ng-container *ngIf="canRead(item)"> + <div class="flex items-center gap-x-3"> + <div class="pointer fa fa-book" title="Usage"></div> + <!-- TODO - handle read only in configure component? --> + <div *ngIf="hasComments(item)"> + <div + class="pointer fa fa-comment" + [delayClose]="false" + nifiTooltip + [tooltipComponentType]="TextTip" + [tooltipInputData]="getCommentsTipData(item)"></div> + </div> + <div *ngIf="hasErrors(item)"> + <div + class="pointer fa fa-warning has-errors" + [delayClose]="false" + nifiTooltip + [tooltipComponentType]="ValidationErrorsTip" + [tooltipInputData]="getValidationErrorsTipData(item)"></div> + </div> + <div *ngIf="hasBulletins(item)"> + <div + class="pointer fa fa-sticky-note-o" + [delayClose]="false" + nifiTooltip + [tooltipComponentType]="BulletinsTip" + [tooltipInputData]="getBulletinsTipData(item)"></div> + </div> + </div> + </ng-container> + </td> + </ng-container> + + <!-- Name Column --> + <ng-container matColumnDef="name"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>Name</th> + <td mat-cell *matCellDef="let item"> + <ng-container *ngIf="canRead(item); else nameNoPermissions"> + {{ item.component.name }} + </ng-container> + <ng-template #nameNoPermissions> + <div class="unset">{{ item.id }}</div> + </ng-template> + </td> + </ng-container> + + <!-- Type Column --> + <ng-container matColumnDef="type"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>Type</th> + <td mat-cell *matCellDef="let item"> + <ng-container *ngIf="canRead(item)"> + {{ formatType(item) }} + </ng-container> + </td> + </ng-container> + + <!-- Bundle Column --> + <ng-container matColumnDef="bundle"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>Bundle</th> + <td mat-cell *matCellDef="let item"> + <ng-container *ngIf="canRead(item)"> + {{ formatBundle(item) }} + </ng-container> + </td> + </ng-container> + + <!-- State Column --> + <ng-container matColumnDef="state"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>State</th> + <td mat-cell *matCellDef="let item"> + <div class="flex items-center gap-x-2"> + <div [ngClass]="getStateIcon(item)"></div> + <div>{{ formatState(item) }}</div> + <div *ngIf="hasActiveThreads(item)">({{ item.status.activeThreadCount }})</div> + </div> + </td> + </ng-container> + + <!-- Actions Column --> + <ng-container matColumnDef="actions"> + <th mat-header-cell *matHeaderCellDef></th> + <td mat-cell *matCellDef="let item"> + <div class="flex items-center gap-x-3"> + <div + class="pointer fa fa-gear" + *ngIf="canConfigure(item)" + (click)="configureClicked(item, $event)" + title="Edit"></div> + <!-- TODO - handle read only in configure component? --> + <div + class="pointer fa icon icon-enable-false" + *ngIf="canDisable(item)" + (click)="disableClicked(item, $event)" + title="Disable"></div> + <div + class="pointer fa fa-flash" + *ngIf="canEnable(item)" + (click)="enabledClicked(item, $event)" + title="Enable"></div> + <div class="pointer fa fa-exchange" *ngIf="canChangeVersion(item)" title="Change Version"></div> + <div + class="pointer fa fa-trash" + *ngIf="canDelete(item)" + (click)="deleteClicked(item)" + title="Delete"></div> + <div class="pointer fa fa-tasks" *ngIf="canViewState(item)" title="View State"></div> + </div> + <div class="pointer fa fa-key" *ngIf="canManageAccessPolicies()" title="Access Policies"></div> Review Comment: ok I think I mixed up the Enforcement policy with access policy. I can remove this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
