lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1463029693
##########
docker/test/integration/features/environment.py:
##########
@@ -47,6 +47,13 @@ def before_scenario(context, scenario):
logging.info("Integration test setup at
{time:%H:%M:%S.%f}".format(time=datetime.datetime.now()))
context.test = MiNiFi_integration_test(context=context,
feature_id=context.feature_id)
+
+ if "USE_NIFI_PYTHON_PROCESSORS" in scenario.effective_tags:
+ if not context.image_store.is_conda_available_in_minifi_image() and
context.image_store.get_minifi_image_python_version() < (3, 8, 1):
+ scenario.skip("NiFi Python processor tests use langchain library
therefore Python 3.8.1 or later is needed in the MiNiFi container.")
Review Comment:
Updated in e8757f9c370b2ec92866a3731af1e6d9ae0edb74
##########
libminifi/include/core/ProcessContext.h:
##########
@@ -135,6 +135,10 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
return getProperty(property.name, value);
}
+ virtual bool getProperty(bool /*supports_expression_language*/,
std::string_view property_name, std::string& value, const
std::shared_ptr<FlowFile>& /*flow_file*/) {
+ return getProperty(property_name, value);
+ }
Review Comment:
Updated in e8757f9c370b2ec92866a3731af1e6d9ae0edb74
##########
extensions/python/PythonProcessor.h:
##########
@@ -37,7 +38,7 @@ class PythonProcessor {
void setDescription(const std::string& desc);
- void addProperty(const std::string& name, const std::string& description,
const std::string& defaultvalue, bool required, bool el);
+ void addProperty(const std::string& name, const std::string& description,
const std::optional<std::string>& defaultvalue, bool required, bool el, const
std::optional<int64_t>& validator_value);
Review Comment:
Updated in e8757f9c370b2ec92866a3731af1e6d9ae0edb74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
