lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1465177492


##########
extensions/python/ExecutePythonProcessor.h:
##########
@@ -118,7 +126,30 @@ class ExecutePythonProcessor : public core::Processor {
     return description_;
   }
 
+  void setPythonClassName(const std::string& python_class_name) {
+    python_class_name_ = python_class_name;
+  }
+
+  void setPythonPaths(const std::vector<std::filesystem::path>& python_paths) {
+    python_paths_ = python_paths;
+  }
+
+ protected:
+  core::Property* findProperty(const std::string& name) const override;
+
  private:
+  enum class PropertyTypeCode : int64_t {
+    INTEGER_TYPE = 0,
+    LONG_TYPE = 1,
+    BOOLEAN_TYPE = 2,
+    DATA_SIZE_TYPE = 3,
+    TIME_PERIOD_TYPE = 4,
+    NON_BLANK_TYPE = 5,
+    PORT_TYPE = 6
+  };

Review Comment:
   This is actually a reference to our `StandardPropertyTypes` found in MiNiFi 
defined in the `libminifi/include/core/PropertyType.h` header, but we can 
remove the suffix and I suppose it's better to have it as part of the 
`core::PropertyType`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to