joewitt commented on code in PR #8350:
URL: https://github.com/apache/nifi/pull/8350#discussion_r1476441590
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java:
##########
@@ -139,6 +145,20 @@ public class UnpackContent extends AbstractProcessor {
PackageFormat.FLOWFILE_STREAM_FORMAT_V2.toString(),
PackageFormat.FLOWFILE_TAR_FORMAT.toString())
.defaultValue(PackageFormat.AUTO_DETECT_FORMAT.toString())
.build();
+ public static final PropertyDescriptor ZIP_FILENAMES_ENCODING = new
PropertyDescriptor.Builder()
+ .name("zip-filenames-encoding")
+ .displayName("Zip Filenames Encoding")
+ .description(
+ "The encoding used by zip creating utility, for the file names
inside the zip. Processor will pass this encoding to Zip unpacker. For example
'Cp437', 'UTF8' etc. Default is to "
Review Comment:
Instead of describing the Cp437 scenario in the property description
consider creating an '@UseCase' annotation to describe the specific case and
how the whole processor would be configured. See 'PublishSlack' for an example
of this done well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
