dan-s1 commented on code in PR #8350:
URL: https://github.com/apache/nifi/pull/8350#discussion_r1476463929
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java:
##########
@@ -231,7 +252,10 @@ public void onScheduled(ProcessContext context) throws
ProcessException {
}
final PropertyValue allowStoredEntriesWithDataDescriptorVal =
context.getProperty(ALLOW_STORED_ENTRIES_WITH_DATA_DESCRIPTOR);
final boolean allowStoredEntriesWithDataDescriptor =
allowStoredEntriesWithDataDescriptorVal.isSet() ?
allowStoredEntriesWithDataDescriptorVal.asBoolean() : false;
- zipUnpacker = new ZipUnpacker(fileFilter, password,
allowStoredEntriesWithDataDescriptor);
+ final PropertyValue filenamesEncodingVal =
context.getProperty(ZIP_FILENAMES_ENCODING);
+
+ Charset filenamesEncoding =filenamesEncodingVal.isSet() ?
Charsets.toCharset(filenamesEncodingVal.getValue()) : Charset.defaultCharset();
Review Comment:
See prior comment
```suggestion
final String filenamesEncodingVal =
context.getProperty(ZIP_FILENAMES_ENCODING).getValue();
final Charset filenamesEncoding =
Charsets.toCharset(filenamesEncodingVal);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
