lordgamez commented on code in PR #1724:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1724#discussion_r1486368105
##########
CMakeLists.txt:
##########
@@ -325,20 +325,33 @@ include(MagicEnum)
# Setup warning flags
if(MSVC)
+set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} /W3)
if(FAIL_ON_WARNINGS)
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")
+ set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} /WX)
endif()
else()
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+ set(MINIFI_CPP_COMPILE_OPTIONS ${MINIFI_CPP_COMPILE_OPTIONS} -Wall -Wextra
-Wno-reorder)
Review Comment:
Good point, it was set in libminifi for some reason so I moved it to the
minificpp compile options. I removed it and fixed the libminifi issues in
f53b73d0a9f001cc4b7d4b1d82950b50855b43af
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
