fgerlits commented on code in PR #1724:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1724#discussion_r1505650786
##########
extensions/coap/CMakeLists.txt:
##########
@@ -31,8 +31,8 @@ include_directories(../http-curl/)
file(GLOB CSOURCES "nanofi/*.c")
file(GLOB SOURCES "*.cpp" "protocols/*.cpp" "processors/*.cpp"
"controllerservice/*.cpp" "server/*.cpp" )
-add_library(nanofi-coap-c STATIC ${CSOURCES})
-add_library(minifi-coap SHARED ${SOURCES})
+add_minifi_library(nanofi-coap-c STATIC "${CSOURCES}")
+add_minifi_library(minifi-coap SHARED "${SOURCES}")
Review Comment:
Are you sure we want to add these new `""`s? I would expect this means that
now we are passing the list of sources as a single argument instead of a list
of separate arguments; do we need to / do we want to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
