joewitt commented on PR #8390: URL: https://github.com/apache/nifi/pull/8390#issuecomment-1939182545
I don't have a lot to add to the comments I see already. But the main gist is if the intent of the JIRA is now broader than the original title please change the JIRA. If the intent has not changed then please narrow the PR. So either this is about adding this option to ListSFTP or it is about others. Would be important to validate each case which expands the scope of the review. Given we don't actually get to, it appears, change the behavior of the SFTP commands executed on the remote end (ie: once you start a listing in a large directory...much of the damage is already done in terms of time/waiting) then the benefit of this property being available is mostly to protect the NiFi side. Still useful just probably not the truly desired/most beneficial impact. I'd avoid *any* changes for now that aren't central to the specific desired improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
