exceptionfactory commented on code in PR #8390:
URL: https://github.com/apache/nifi/pull/8390#discussion_r1486581589
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##########
@@ -317,6 +317,12 @@ protected void getListing(final String path, final int
depth, final int maxResul
final RemoteResourceFilter filter = (entry) -> {
final String entryFilename = entry.getName();
+ // Since SSHJ does not have the concept of BREAK that JSCH
had, we need to move this before the call to listing.add
+ // below, otherwise we would keep adding to the listings since
returning false here doesn't break
+ if (listing.size() >= maxResults) {
+ return false;
+ }
+
Review Comment:
Is this change necessary? It seems useful in some circumstances, but not
needed for this particular property change.
##########
nifi-nar-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java:
##########
@@ -29,6 +29,7 @@
import org.apache.nifi.processor.ProcessSession;
import org.apache.nifi.processor.exception.ProcessException;
import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processor.util.list.AbstractListProcessor;
Review Comment:
This change can be reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
