lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1500709305
##########
extensions/python/types/Types.h:
##########
@@ -160,7 +160,18 @@ class Long : public ReferenceHolder<reference_type> {
}
int64_t asInt64() {
- return static_cast<int64_t>(PyLong_AsLongLong(this->ref_.get()));
+ auto long_value = PyLong_AsLongLong(this->ref_.get());
+ if (long_value == -1 && PyErr_Occurred()) {
+ throw PyException();
+ }
+ return static_cast<int64_t>(long_value);
Review Comment:
Updated in 6593d9b63514dd2a3b2060b747680f37691abecd
##########
libminifi/src/core/ConfigurableComponent.cpp:
##########
@@ -36,19 +36,28 @@ ConfigurableComponent::ConfigurableComponent()
ConfigurableComponent::~ConfigurableComponent() = default;
+Property* ConfigurableComponent::findProperty(const std::string& name) const {
Review Comment:
Updated in 6593d9b63514dd2a3b2060b747680f37691abecd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
