lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1500838899
##########
extensions/python/ExecutePythonProcessor.h:
##########
@@ -97,10 +99,8 @@ class ExecutePythonProcessor : public core::Processor {
python_dynamic_ = true;
}
- void addProperty(const std::string &name, const std::string &description,
const std::string &defaultvalue, bool required, bool el) {
- python_properties_.emplace_back(
-
core::PropertyDefinitionBuilder<>::createProperty(name).withDefaultValue(defaultvalue).withDescription(description).isRequired(required).supportsExpressionLanguage(el).build());
- }
+ void addProperty(const std::string &name, const std::string &description,
const std::optional<std::string> &defaultvalue, bool required, bool el,
+ bool sensitive, const std::optional<int64_t>& property_type_code);
const std::vector<core::Property> &getPythonProperties() const {
return python_properties_;
Review Comment:
Good point, updated in d3f47c57d21829d1715bd794f8c08a462f4fa361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
