lordgamez commented on PR #1731: URL: https://github.com/apache/nifi-minifi-cpp/pull/1731#issuecomment-1961546852
> Do you think we could use rocksdb ini files to make these settings user-overridable? https://github.com/facebook/rocksdb/wiki/RocksDB-Options-File Unfortunately when loading config from a file using `LoadOptionsFromFile` returns a whole `DBOptions` object overwriting all previously read config values we retrieved using `LoadLatestOptions`, and patched with our custom values. Fortunately I found that `rocksdb::GetDBOptionsFromMap` can update previously read `DBOptions` object from an unordered map. This way we can update any rocksdb option from the minifi.properties file. I updated the PR in 84441ba21b1cf0850e25807356a730ee30040cd2 to be able to override any RocksDB option defined in the properties file with the `nifi.global.rocksdb.options.` prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
