szaszm commented on code in PR #1731:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1731#discussion_r1502750440
##########
extensions/rocksdb-repos/tests/RocksDBUtilsTests.cpp:
##########
Review Comment:
I think we should also test that overriding one of the "common" options,
that we set as different defaults, works as well, for example overriding
use_direct_reads to false.
##########
CONFIGURE.md:
##########
@@ -425,6 +425,20 @@ Rocksdb has an option to run compaction at specific
intervals not just when need
nifi.flowfile.repository.rocksdb.compaction.period=2 min
nifi.database.content.repository.rocksdb.compaction.period=2 min
+### Global RocksDB options
+
+There are a few options for RocksDB that are set for all used RocksDB
databases in MiNiFi:
+ `create_if_missing` is set to `true`
+ `use_direct_io_for_flush_and_compaction` is set to `true`
+ `use_direct_reads` is set to `true`
+ `keep_log_file_num` is set to `5`
+
+Any RocksDB option can be set or overriden using the
`nifi.global.rocksdb.options.` prefix in the minifi.properties file.
Review Comment:
Not sure how much extra complexity would this add, but it would be nice to
be able to override settings on a per-repo basis as well, separately for flow
file and content repositories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
