dan-s1 commented on code in PR #8450:
URL: https://github.com/apache/nifi/pull/8450#discussion_r1502812107
##########
nifi-commons/nifi-record-path/src/test/java/org/apache/nifi/record/path/TestRecordPath.java:
##########
@@ -2115,4 +2068,11 @@ private Record createSimpleRecord() {
return new MapRecord(schema, values);
}
+ private static FieldValue evaluateSingleFieldValue(RecordPath recordPath,
Record record) {
+ return
recordPath.evaluate(record).getSelectedFields().findFirst().get();
+ }
+
+ private static FieldValue evaluateSingleFieldValue(String path, Record
record) {
+ return evaluateSingleFieldValue(RecordPath.compile(path), record);
+ }
Review Comment:
@EndzeitBegins I appreciate you adding these methods and the unit test
`testRecordRootReferenceInFunction` to exercise the bug you fixed but all the
other changes just to use these method(s) do not relate to this ticket. Can you
please create a follow on ticket and make those changes with these methods? It
makes reviewing the code much easier. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
