EndzeitBegins commented on code in PR #8450:
URL: https://github.com/apache/nifi/pull/8450#discussion_r1508004037
##########
nifi-commons/nifi-record-path/src/test/java/org/apache/nifi/record/path/TestRecordPath.java:
##########
@@ -2115,4 +2068,11 @@ private Record createSimpleRecord() {
return new MapRecord(schema, values);
}
+ private static FieldValue evaluateSingleFieldValue(RecordPath recordPath,
Record record) {
+ return
recordPath.evaluate(record).getSelectedFields().findFirst().get();
+ }
+
+ private static FieldValue evaluateSingleFieldValue(String path, Record
record) {
+ return evaluateSingleFieldValue(RecordPath.compile(path), record);
+ }
Review Comment:
Thank you for the feedback @dan-s1.
That's why I split the PR into two commits. But you're right that the PR
should be focused on the required changes only.
I reduced this PR to a single commit with just the changes needed.
I'd appreciate a review.
I might open a separate PR for the test refactorings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
