knguyen1 commented on PR #8417: URL: https://github.com/apache/nifi/pull/8417#issuecomment-1975401486
I fixed failing tests and build failures from the latest code review. Everything's passing now. @exceptionfactory I had to add this method: `EncodingType getEncodingTypeFromString(final String encodingTypeValue)` because previous implementation used `hex` instead of `hexadecimal` as in @exceptionfactory's suggestion. So we can't easily use `EncodingType.valueOf` anymore. Latest is pending the resolution of comments regarding. > Is this property necessary? It seems best to hard-code the line-feed character `\n`, rather than making this platform-dependent or configurable. > This description needs some rewording and clarification. It is not clear why it is rounded to a multiple of 4, and again, the conditional nature of the property does not need to be stated. I have left those threads unresolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
