dan-s1 commented on code in PR #8417: URL: https://github.com/apache/nifi/pull/8417#discussion_r1511285858
########## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncodeContent.java: ########## @@ -237,4 +297,14 @@ public void process(final InputStream in, final OutputStream out) throws IOExcep out.flush(); } } + + private static EncodingType getEncodingTypeFromString(final String encodingTypeValue) { + if (encodingTypeValue.compareToIgnoreCase("base64") == 0) { + return EncodingType.BASE64; + } else if (encodingTypeValue.compareToIgnoreCase("base32") == 0) { + return EncodingType.BASE32; Review Comment: ```suggestion if (EncodingType.BASE64.getValue().equals(encodingTypeValue)) { return EncodingType.BASE64; } else if (EncodingType.BASE32.getValue().equals(encodingTypeValue)) { return EncodingType.BASE32; ``` ########## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncodeContent.java: ########## @@ -237,4 +297,14 @@ public void process(final InputStream in, final OutputStream out) throws IOExcep out.flush(); } } + + private static EncodingType getEncodingTypeFromString(final String encodingTypeValue) { Review Comment: No need to add suffix `FromString` as it is obvious from the argument. ```suggestion private static EncodingType getEncodingType(final String encodingTypeValue) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org