szaszm commented on code in PR #1681:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1511242466
##########
.github/workflows/ci.yml:
##########
@@ -75,12 +131,72 @@ jobs:
timeout-minutes: 240
env:
LUA_DIR: D:\a\nifi-minifi-cpp\nifi-minifi-cpp\.lua
+ WINDOWS_MINIFI_OPTIONS: >-
+ -DCMAKE_BUILD_TYPE=Release
+ -DBUILD_ROCKSDB=ON
+ -DBUILD_SHARED_LIBS=OFF
+ -DCI_BUILD=ON
+ -DCUSTOM_MALLOC=OFF
+ -DDOCKER_BUILD_ONLY=OFF
+ -DDOCKER_PUSH=OFF
+ -DDOCKER_SKIP_TESTS=ON
+ -DENABLE_ALL=OFF
+ -DENABLE_AWS=ON
+ -DENABLE_AZURE=ON
+ -DENABLE_BUSTACHE=OFF
+ -DENABLE_BZIP2=ON
+ -DENABLE_CIVET=ON
+ -DENABLE_COAP=OFF
+ -DENABLE_CONTROLLER=OFF
Review Comment:
Now that you fixed its build, I think we should enable the controller even
on Windows.
##########
bootstrap/py_bootstrap.bat:
##########
@@ -0,0 +1,29 @@
+@echo off
+
+REM Check if Python is installed
+where python > nul 2>&1
+if %errorlevel% neq 0 (
+ echo Python is not installed
+ exit /b 1
+)
+
+REM Check if venv module is available
+python -m venv --help > nul 2>&1
+if %errorlevel% neq 0 (
+ echo venv module is not available
+ exit /b 1
+)
+
+set "SCRIPT_DIR=%~dp0"
+set "VENV_DIR=%SCRIPT_DIR%venv"
+
+if exist "%VENV_DIR%" (
+ call "%VENV_DIR%\Scripts\activate"
+) else (
+ echo Creating virtualenv
+ python -m venv "%VENV_DIR%"
+ call "%VENV_DIR%\Scripts\activate"
Review Comment:
Aren't we supposed to call activate.bat here? Why does this even work?
##########
Windows.md:
##########
@@ -120,7 +120,7 @@ A basic working CMake configuration can be inferred from
the `win_build_vs.bat`.
```
mkdir build
cd build
-cmake -G "Visual Studio 17 2022" -A x64 -DINSTALLER_MERGE_MODULES=OFF
-DTEST_CUSTOM_WEL_PROVIDER=OFF -DENABLE_SQL=OFF -DUSE_REAL_ODBC_TEST_DRIVER=OFF
-DCMAKE_BUILD_TYPE_INIT=Release -DCMAKE_BUILD_TYPE=Release -DWIN32=WIN32
-DENABLE_LIBRDKAFKA=OFF -DENABLE_JNI=OFF -DOPENSSL_OFF=OFF -DENABLE_COAP=OFF
-DENABLE_AWS=OFF -DENABLE_PDH= -DENABLE_AZURE=OFF -DENABLE_SFTP=OFF
-DENABLE_SPLUNK= -DENABLE_GCP= -DENABLE_NANOFI=OFF -DENABLE_OPENCV=OFF
-DENABLE_PROMETHEUS=OFF -DENABLE_ELASTICSEARCH= -DUSE_SHARED_LIBS=OFF
-DENABLE_CONTROLLER=ON -DENABLE_BUSTACHE=OFF -DENABLE_COAP=OFF
-DENABLE_ENCRYPT_CONFIG=OFF -DENABLE_GPS=OFF -DENABLE_LUA_SCRIPTING=OFF
-DENABLE_MQTT=OFF -DENABLE_OPC=OFF -DENABLE_OPENWSMAN=OFF -DENABLE_OPS=OFF
-DENABLE_PCAP=OFF -DENABLE_PYTHON_SCRIPTING= -DENABLE_SENSORS=OFF
-DENABLE_USB_CAMERA=OFF -DBUILD_ROCKSDB=ON -DFORCE_WINDOWS=ON
-DUSE_SYSTEM_UUID=OFF -DDISABLE_LIBARCHIVE=OFF -DENABLE_WEL=ON
-DFAIL_ON_WARNINGS=OFF -DSKIP_TESTS=OFF ..
+cmake -G "Visual Studio 16 2022" -A x64 -DINSTALLER_MERGE_MODULES=OFF
-DTEST_CUSTOM_WEL_PROVIDER=OFF -DENABLE_SQL=OFF
-DMINIFI_USE_REAL_ODBC_TEST_DRIVER=OFF -DCMAKE_BUILD_TYPE_INIT=Release
-DCMAKE_BUILD_TYPE=Release -DWIN32=WIN32 -DENABLE_LIBRDKAFKA=OFF
-DENABLE_JNI=OFF -DMINIFI_OPENSSL=ON -DENABLE_COAP=OFF -DENABLE_AWS=OFF
-DENABLE_PDH= -DENABLE_AZURE=OFF -DENABLE_SFTP=OFF -DENABLE_SPLUNK=
-DENABLE_GCP= -DENABLE_NANOFI=OFF -DENABLE_OPENCV=OFF -DENABLE_PROMETHEUS=OFF
-DENABLE_ELASTICSEARCH= -DUSE_SHARED_LIBS=OFF -DENABLE_CONTROLLER=ON
-DENABLE_BUSTACHE=OFF -DENABLE_COAP=OFF -DENABLE_ENCRYPT_CONFIG=OFF
-DENABLE_GPS=OFF -DENABLE_LUA_SCRIPTING=OFF -DENABLE_MQTT=OFF -DENABLE_OPC=OFF
-DENABLE_OPENWSMAN=OFF -DENABLE_OPS=OFF -DENABLE_PCAP=OFF
-DENABLE_PYTHON_SCRIPTING= -DENABLE_SENSORS=OFF -DENABLE_USB_CAMERA=OFF
-DBUILD_ROCKSDB=ON -DUSE_SYSTEM_UUID=OFF -DENABLE_LIBARCHIVE=ON -DENABLE_WEL=ON
-DMINIFI_FAIL_ON_WARNINGS=OFF -DSKIP_TESTS=OFF ..
Review Comment:
On my machine, there's `Visual Studio 16 2019` and `Visual Studio 17 2022`,
but no `Visual Studio 16`. Was this change made by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
