szaszm commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1514586297
########## bootstrap/py_bootstrap.bat: ########## @@ -0,0 +1,29 @@ +@echo off + +REM Check if Python is installed +where python > nul 2>&1 +if %errorlevel% neq 0 ( + echo Python is not installed + exit /b 1 +) + +REM Check if venv module is available +python -m venv --help > nul 2>&1 +if %errorlevel% neq 0 ( + echo venv module is not available + exit /b 1 +) + +set "SCRIPT_DIR=%~dp0" +set "VENV_DIR=%SCRIPT_DIR%venv" + +if exist "%VENV_DIR%" ( + call "%VENV_DIR%\Scripts\activate" +) else ( + echo Creating virtualenv + python -m venv "%VENV_DIR%" + call "%VENV_DIR%\Scripts\activate" Review Comment: I was especially confused, because there is an activate file in the same location without an extension, but it's a bash script. Thx for changing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
