szaszm commented on code in PR #1725:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512869627
##########
libminifi/include/core/ProcessGroup.h:
##########
@@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent {
*/
std::shared_ptr<core::controller::ControllerServiceNode>
findControllerService(const std::string &nodeId) const;
+ std::vector<std::shared_ptr<core::controller::ControllerServiceNode>>
getAllControllerServices() const;
Review Comment:
That would be an improvement. Optionally, they could be wrapped in
gsl::not_null. Whether a const refernce is enough for all consumers also needs
to be considered, but if it is, then less unnecessary exposure is better.
Currently it's pointers to mutable objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
